Please let me know if this needs more tests.

Looks good, so simple. Can we add some docs about this?

Codecov Report

Merging #6767 (bea64cc) into master (7684ef4) will increase coverage by 0.05%.
The diff coverage is 81.57%.

❗ Current head bea64cc differs from pull request most recent head 38bf4aa. Consider uploading reports for the commit 38bf4aa to get more accurate results

@@            Coverage Diff             @@
##           master    #6767      +/-   ##
==========================================
+ Coverage   48.64%   48.70%   +0.05%     
==========================================
  Files         264      265       +1     
  Lines       19076    19108      +32     
==========================================
+ Hits         9279     9306      +27     
- Misses       8752     8757       +5     
  Partials     1045     1045              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7684ef4...38bf4aa. Read the comment docs.

@alexec I'll update the following doc this evening:

• https://github.com/argoproj/argo-workflows/blob/master/docs/argo-server.md

What doc should I update for the workflow-controller?

I think the right places is probably:

https://github.com/argoproj/argo-workflows/blob/master/docs/environment-variables.md

I was wrong about where to add those flags. It fails make codegen. It also means that we need the keep that list up-to-date - which we will fail to do.

Instead, can I ask you to just add a bit like this:

Parameters can be specified as environment variables:

  workflow-controller --managed-namespace=argo

Can be expressed as:

  env MANAGED_NAMESPACE=argo workflow-controller

That makes total sense. I will update the docs/environment-variables.md doc to reflect that suggestion.

Is it possible to have ARGO_ as prefix?

It shouldn't be an issue, it is fairly simple to do with Viper's SetEnvPrefix, I'll fix that.

@alexec, done!

🚀